get all voltage level connections #277
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
ghazwarhili
reviewed
Sep 5, 2025
src/main/java/org/gridsuite/network/map/dto/definition/voltagelevel/FeederBayInfos.java
Outdated
Show resolved
Hide resolved
ghazwarhili
reviewed
Sep 5, 2025
src/main/java/org/gridsuite/network/map/dto/mapper/VoltageLevelInfosMapper.java
Outdated
Show resolved
Hide resolved
ghazwarhili
reviewed
Sep 5, 2025
src/main/java/org/gridsuite/network/map/dto/mapper/VoltageLevelInfosMapper.java
Outdated
Show resolved
Hide resolved
|
etiennehomer
requested changes
Sep 18, 2025
| /** | ||
| * @author Slimane Amar <slimane.amar at rte-france.com> | ||
| */ | ||
| public class BusbarSectionFinderTraverser implements Terminal.TopologyTraverser { |
There was a problem hiding this comment.
Move those changes in another PR. So the review can be done with #288. And the changes in the tests will be reviewed with it
| } | ||
| } | ||
|
|
||
| public static ConnectablePositionInfos toMapConnectablePosition(Identifiable<?> identifiable, int index) { |
There was a problem hiding this comment.
Suggested change
| public static ConnectablePositionInfos toMapConnectablePosition(Identifiable<?> identifiable, int index) { | |
| public static ConnectablePositionInfos getConnectablePosition(Identifiable<?> identifiable, ThreeSides side) { |
There was a problem hiding this comment.
I agree with the renaming, but not with changing int index to ThreeSides side, because we need to specify the index to retrieve the feeder
| } | ||
|
|
||
| static VoltageLevelMapInfos toMapInfos(Identifiable<?> identifiable) { | ||
| private static Map<String, List<FeederBayInfos>> getFeederBaysInfos(VoltageLevel voltageLevel) { |
There was a problem hiding this comment.
private static Map<String, List<FeederBayInfos>> getFeederBaysInfos(VoltageLevel voltageLevel) {
Map<String, List<FeederBayInfos>> feederBayInfos = new HashMap<>();
voltageLevel.getConnectableStream()
.filter(connectable -> !(connectable instanceof BusbarSection))
.forEach(connectable -> {
List<FeederBayInfos> connections = new ArrayList<>();
connectable.getTerminals().forEach(obj -> {
Terminal terminal = (Terminal) obj;
if (terminal.getVoltageLevel().getId().equals(voltageLevel.getId())) {
connections.add(
new FeederBayInfos(
getBusOrBusbarSection(terminal),
getConnectablePosition(connectable, getConnectableSide(terminal).map(side -> side.getNum()).orElse(0)),
getConnectableSide(terminal).orElse(null)
)
);
}
});
feederBayInfos.put(connectable.getId(), connections);
});
return feederBayInfos;
}
There was a problem hiding this comment.
something like this to be more succinct ?
| } | ||
| } | ||
|
|
||
| private static ConnectablePosition.Feeder getFeederInfos(Identifiable<?> identifiable, int index) { |
There was a problem hiding this comment.
This code should use ThreeSides
Suggested change
| private static ConnectablePosition.Feeder getFeederInfos(Identifiable<?> identifiable, int index) { | |
| private static ConnectablePosition.Feeder getFeederInfos(Identifiable<?> identifiable, ThreeSides side) { |
There was a problem hiding this comment.
With the index we can handle injections and branches, but the ThreeSides type cannot manage that
| return convertFeederToConnectablePositionInfos(feeder); | ||
| } | ||
|
|
||
| public static ConnectablePositionInfos convertFeederToConnectablePositionInfos(ConnectablePosition.Feeder feeder) { |
There was a problem hiding this comment.
Suggested change
| public static ConnectablePositionInfos convertFeederToConnectablePositionInfos(ConnectablePosition.Feeder feeder) { | |
| public static ConnectablePositionInfos buildConnectablePositionInfos(ConnectablePosition.Feeder feeder) { |
| final BusbarSectionFinderTraverser connectedBusbarSectionFinder = new BusbarSectionFinderTraverser(terminal.isConnected()); | ||
| terminal.traverse(connectedBusbarSectionFinder, TraversalType.BREADTH_FIRST); | ||
| return connectedBusbarSectionFinder.getFirstTraversedBbsId(); | ||
| // NODE_BREAKER: explore all paths and choose the busbar with the closed disconnector |
There was a problem hiding this comment.
Move those changes in another PR. So the review can be done with #288. And the changes in the tests will be reviewed with it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.